Skip to content

nixbot: migrate from buildbot-nix config & configure stable branches - #9743

Open
MattSturgeon wants to merge 2 commits into
nix-community:masterfrom
MattSturgeon:nixbot-config
Open

nixbot: migrate from buildbot-nix config & configure stable branches#9743
MattSturgeon wants to merge 2 commits into
nix-community:masterfrom
MattSturgeon:nixbot-config

Conversation

@MattSturgeon

Copy link
Copy Markdown
Member

Description

Commit 1

Migrate references to "buildbot" to its replacement, "nixbot" and rename the config file to the new name.
While it probably isn't considered "public API", I added a rename alias to the buildbot flake output.

Commit 2

Explicitly configure nixbot's "build on push" branches, now that it no longer builds all branches by default.

We only need to configure stable branches (release-*), because the default branch and merge-queue branches are always build on push, and Pull Requests are always build (using a different non-push event).

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -A dev --run treefmt.

  • Code tested through nix build .#test-all
    or a targeted nix run .#tests -- <pattern>.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

Nixbot recently added a `build_branches` config option,¹ which allows
specifying additional branches to be built on push. This replaces the
old behaviour where all branches were built on push.

The default branch and merge-queue refs are always built on push and
Pull Requests are considered their own non-push event.

¹: Mic92/nixbot@87c9a40

@khaneliman khaneliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i didn't see this. can you rebase and resolve the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants